Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/control: Lint using cme #1300

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Mar 9, 2021

Change-Id: Ib59e8dd0b489b48b210efb51915b7135695d1438
Fordwarded: https://github.com/theupdateframework/tuf/pulls/rzr
Relate-to: #263
Signed-off-by: Philippe Coval [email protected]

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

rzr added a commit to CrossStream/tuf that referenced this pull request Mar 9, 2021
Change-Id: Ib59e8dd0b489b48b210efb51915b7135695d1438
Fordwarded: theupdateframework#1300
Relate-to: theupdateframework#263
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/upstream/debian/review/master branch from d52cdf1 to b48f732 Compare March 9, 2021 10:36
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @rzr!

debian/control Outdated Show resolved Hide resolved
debian/control Outdated Show resolved Hide resolved
debian/control Show resolved Hide resolved
@rzr
Copy link
Contributor Author

rzr commented Mar 10, 2021

Thanks for the remarks can we take them into account in later patches (from my debian/master branch)
I don't want to mix lint and functional changes
Thanks

rzr added 3 commits March 10, 2021 15:30
Change-Id: Ib59e8dd0b489b48b210efb51915b7135695d1438
Fordwarded: theupdateframework#1300
Relate-to: theupdateframework#263
Signed-off-by: Philippe Coval <[email protected]>
It was removed since v0.15.0

Thanks-to: <Lukas Puehringer <[email protected]>
Relate-to: theupdateframework#263
Signed-off-by: Philippe Coval <[email protected]>
Change-Id: I4f19349f135bff1fce3590143900fa7c63d21c5d
Relate-to: theupdateframework#263
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/upstream/debian/review/master branch from b48f732 to 9b79197 Compare March 10, 2021 14:31
@joshuagl
Copy link
Member

joshuagl commented Mar 10, 2021

Hi @rzr. I really appreciate your interest in the project, but I'm not sure it makes sense to spend significant effort packaging tuf for Debian at this time.

We're embarking on a refactoring effort and hoping to make a 1.0 release in the foreseeable future, so any package we create today is unlikely to be useful, or supported, for a Debian release cycle and will likely to need overhauling once the refactoring effort is complete.

If you are interested in the project outside of Debian packaging, we'd be happy to help you find some reasonable issues to work on. Otherwise we would be very grateful for your packaging efforts once the refactor has started to take shape and we have a good idea of what to package.

Relate-to: https://lists.debian.org/debian-python/2021/03/msg00005.html
Change-Id: Idc7f396a6dd2447c35f82d0a63641e1d4c203c61
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit to CrossStream/tuf that referenced this pull request Jun 16, 2021
Change-Id: Ib59e8dd0b489b48b210efb51915b7135695d1438
Fordwarded: theupdateframework#1300
Relate-to: theupdateframework#263
Signed-off-by: Philippe Coval <[email protected]>
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution, @rzr!

This is an enhancement to the debian branch (PR target), so I will go ahead and merge.

To finalize this work the debian branch will need to be rebased on develop, which has seen lots of development since this PR was opened (see @joshuagl's refactoring comment above).

This packaging effort will continue to be tracked in #263.

@lukpueh lukpueh merged commit 6d46833 into theupdateframework:debian Feb 17, 2022
@rzr
Copy link
Contributor Author

rzr commented Feb 17, 2022

ok thx I'll push more changes that could be also useful in current debian branch, please hold rebase a couple of days then you can resume where I was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants